Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

actionify get policy API #307

Merged
bowenlan-amzn merged 3 commits into from
Oct 13, 2020
Merged

actionify get policy API #307

bowenlan-amzn merged 3 commits into from
Oct 13, 2020

Conversation

@bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Oct 13, 2020

Issue #, if available:
#292

Description of changes:
actionify get policy API, refactor our API code so we have an action name to each API

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bowenlan-amzn bowenlan-amzn added the enhancement An improvement on the existing feature’s functionalities label Oct 13, 2020
@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review October 13, 2020 03:41
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #307 into master will increase coverage by 0.13%.
The diff coverage is 91.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #307      +/-   ##
============================================
+ Coverage     74.96%   75.09%   +0.13%     
- Complexity      829      850      +21     
============================================
  Files           116      120       +4     
  Lines          4442     4506      +64     
  Branches        670      674       +4     
============================================
+ Hits           3330     3384      +54     
- Misses          751      756       +5     
- Partials        361      366       +5
Impacted Files Coverage Δ Complexity Δ
...ment/transport/action/getpolicy/GetPolicyAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
...ent/transport/action/getpolicy/GetPolicyRequest.kt 80.95% <80.95%> (ø) 7.00 <7.00> (?)
...sport/action/getpolicy/TransportGetPolicyAction.kt 92.59% <92.59%> (ø) 3.00 <3.00> (?)
...nt/transport/action/getpolicy/GetPolicyResponse.kt 96.77% <96.77%> (ø) 10.00 <10.00> (?)
...ticsearch/indexmanagement/IndexManagementPlugin.kt 91.54% <100.00%> (+0.12%) 9.00 <0.00> (ø)
...statemanagement/resthandler/RestGetPolicyAction.kt 85.71% <100.00%> (-8.23%) 5.00 <0.00> (-1.00)
...nt/indexstatemanagement/model/destination/Chime.kt 40.90% <0.00%> (-13.64%) 2.00% <0.00%> (-2.00%)
...anagement/indexstatemanagement/model/Transition.kt 64.61% <0.00%> (-3.08%) 5.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3342a6...d3b93c3. Read the comment docs.

@bowenlan-amzn bowenlan-amzn merged commit 0c24f32 into opendistro-for-elasticsearch:master Oct 13, 2020
@bowenlan-amzn bowenlan-amzn deleted the add-getpolicy-pr branch February 9, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dbbaughe dbbaughe dbbaughe approved these changes

@qreshi qreshi qreshi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement An improvement on the existing feature’s functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bowenlan-amzn @dbbaughe @qreshi